Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Template Tab Improvements #77

Merged
merged 19 commits into from
Aug 5, 2024
Merged

UI Template Tab Improvements #77

merged 19 commits into from
Aug 5, 2024

Conversation

buehlefs
Copy link
Contributor

@buehlefs buehlefs commented Aug 2, 2024

  • Allow for custom icons in template tabs
  • Allow for nested tab groups (only in nav bar)
  • Make plugin tab component more robust

Requires UST-QuAntiL/qhana-plugin-registry#31 to work correctly!

@buehlefs
Add custom scrollbar styles
701ffcc
@buehlefs
Fix potential cyclic updates during angular change detection
e518652
@buehlefs
Remove list item decorations in growing list component
eca828d
@buehlefs
Refactor plugin sidebar styles to allow independent scrolling in sidebar
a1e1288
@buehlefs
Add icon support to plugin groups in sidebar
456cfa8 
Add icon support for plugin groups (only used by default template for now)
Autoscroll plugin group into view
@buehlefs
Refactor tab group sorting and prefer group link name in some cases
a917eb9
@buehlefs
Fix plugin filter editor error on empty string inputs
ccb9390
@buehlefs
Add group_key and icon attributes to template tab object and edit form
ebba207
@buehlefs
Display group key for group tabs in template details
9f7c6c0
@buehlefs
Display tab icons and group indicator in nav bar
2365e88
@buehlefs
Use tab icons in plugin sidebar
ad732c2
@buehlefs
Reimplement plugin tab component to work with nested groups and displ…
86fce95 
…ay icons
@buehlefs buehlefs requested a review from PhilWun August 2, 2024 10:23
PhilWun
PhilWun approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@PhilWun PhilWun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buehlefs buehlefs marked this pull request as ready for review August 5, 2024 14:34
@buehlefs buehlefs merged commit 6a6f3b8 into main Aug 5, 2024
2 checks passed
@buehlefs buehlefs deleted the feature/extended-template-tabs branch August 5, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilWun PhilWun PhilWun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buehlefs @PhilWun